components/network_session_configurator/network_session_configurator.cc - Issue 2546533003: Respect QuicAllowed policy for new streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2546533003: Respect QuicAllowed policy for new streams (Closed)

Patch Set: IOS io_thread also initializes DynamicSharedParams Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_impl.cc ('K') | « components/grpc_support/test/get_stream_engine.cc ('k') | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | ios/chrome/browser/ios_chrome_io_thread.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_session_configurator/network_session_configurator.cc

diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc

index e1c9bb0beead771a76170cd79e6d37abfe26505f..655d4c41908d48fd852aa97d8a7272634ac7920f 100644

--- a/components/network_session_configurator/network_session_configurator.cc

+++ b/components/network_session_configurator/network_session_configurator.cc

@@ -284,7 +284,7 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,

bool is_quic_force_enabled,

const std::string& quic_user_agent_id,

net::HttpNetworkSession::Params* params) {

- params->enable_quic = ShouldEnableQuic(

+ params->dynamic_shared_params->enable_quic = ShouldEnableQuic(

quic_trial_group, is_quic_force_disabled, is_quic_force_enabled);

params->disable_quic_on_timeout_with_open_streams =

ShouldDisableQuicWhenConnectionTimesOutWithOpenStreams(quic_trial_params);

@@ -292,7 +292,7 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,

params->enable_quic_alternative_service_with_different_host =

ShouldQuicEnableAlternativeServicesForDifferentHost(quic_trial_params);

- if (params->enable_quic) {

+ if (params->enable_quic()) {

params->quic_always_require_handshake_confirmation =

ShouldQuicAlwaysRequireHandshakeConfirmation(quic_trial_params);

params->quic_disable_connection_pooling =