Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2546473005: [DevTools] Remove unnecessary checks for project types. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove unnecessary checks for project types. This moves us closer to separating users of file system projects from network ones, and just makes code cleaner. Eventual goal is to remove project types completely. BUG=670180 Committed: https://crrev.com/1ac525d4bdbec3318eae77ded7a1ff83f52f1b5f Cr-Commit-Position: refs/heads/master@{#435856}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed comment #

Messages

Total messages: 15 (9 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-01 07:06:22 UTC) #4
lushnikov
lgtm https://codereview.chromium.org/2546473005/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js (left): https://codereview.chromium.org/2546473005/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js#oldcode245 third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:245: if (uiSourceCode.project().type() === Workspace.projectTypes.FileSystem) let's bring this back ...
4 years ago (2016-12-02 01:31:32 UTC) #7
dgozman
https://codereview.chromium.org/2546473005/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js (left): https://codereview.chromium.org/2546473005/diff/1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js#oldcode245 third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:245: if (uiSourceCode.project().type() === Workspace.projectTypes.FileSystem) On 2016/12/02 01:31:32, lushnikov wrote: ...
4 years ago (2016-12-02 02:33:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546473005/20001
4 years ago (2016-12-02 02:33:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 04:29:32 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 04:32:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ac525d4bdbec3318eae77ded7a1ff83f52f1b5f
Cr-Commit-Position: refs/heads/master@{#435856}

Powered by Google App Engine
This is Rietveld 408576698