third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js - Issue 2546473005: [DevTools] Remove unnecessary checks for project types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

Issue 2546473005: [DevTools] Remove unnecessary checks for project types. (Closed)

Patch Set: fixed comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js b/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

index 3e9b88f9bc2f26202a1e45d3d4154bffdb26c689..80d29525dc2ec06ff1fc3f4020ee540107730538 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js

@@ -206,11 +206,11 @@ Sources.ScriptFormatterEditorAction = class {

_isFormatableScript(uiSourceCode) {

if (!uiSourceCode)

return false;

- if (Persistence.persistence.binding(uiSourceCode))

+ if (uiSourceCode.project().canSetFileContent())

+ return false;

+ if (uiSourceCode.project().type() === Workspace.projectTypes.Formatter)

return false;

- var supportedProjectTypes =

- [Workspace.projectTypes.Network, Workspace.projectTypes.Debugger, Workspace.projectTypes.ContentScripts];

- if (supportedProjectTypes.indexOf(uiSourceCode.project().type()) === -1)

+ if (Persistence.persistence.binding(uiSourceCode))

return false;

return uiSourceCode.contentType().hasScripts();

}