Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2546433002: Fix flakiness in SSLErrorHandlerDateInvalidTest tests (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in SSLErrorHandlerDateInvalidTest tests Setting the testing build time ensures that the test passes even if the system clock is incorrect when running the test. BUG=666821, 668539 Committed: https://crrev.com/f6da1461c10818dd99c0a08709bb4e7eee6df94a Cr-Commit-Position: refs/heads/master@{#435584}

Patch Set 1 #

Patch Set 2 : correct upstream branch #

Total comments: 1

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ssl/ssl_error_handler_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
battre
Hi Emily, could you please review this CL? I think it is a similar case ...
4 years ago (2016-11-30 13:16:53 UTC) #4
estark
lgtm, thanks! https://codereview.chromium.org/2546433002/diff/20001/chrome/browser/ssl/ssl_error_handler_unittest.cc File chrome/browser/ssl/ssl_error_handler_unittest.cc (right): https://codereview.chromium.org/2546433002/diff/20001/chrome/browser/ssl/ssl_error_handler_unittest.cc#newcode227 chrome/browser/ssl/ssl_error_handler_unittest.cc:227: // Fix flakiness in case system time ...
4 years ago (2016-12-01 00:17:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546433002/40001
4 years ago (2016-12-01 08:10:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 08:42:12 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 08:46:26 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f6da1461c10818dd99c0a08709bb4e7eee6df94a
Cr-Commit-Position: refs/heads/master@{#435584}

Powered by Google App Engine
This is Rietveld 408576698