Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2532273003: Fix flaky GetClockState test (Closed)

Created:
4 years ago by estark
Modified:
4 years ago
Reviewers:
meacer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky GetClockState test Setting the testing build time ensures that the test passes even if the system clock is incorrect when running the test. BUG=668539 Committed: https://crrev.com/5e544a08ab677f679c3f5b0c74112140e2f0b8d4 Cr-Commit-Position: refs/heads/master@{#434835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/ssl_errors/error_classification_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
estark
meacer, PTAL?
4 years ago (2016-11-28 23:23:17 UTC) #2
meacer
LGTM. Does this mean try bots have clocks in the future?
4 years ago (2016-11-28 23:44:12 UTC) #3
estark
On 2016/11/28 23:44:12, Mustafa Emre Acer wrote: > LGTM. Does this mean try bots have ...
4 years ago (2016-11-28 23:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532273003/1
4 years ago (2016-11-28 23:55:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:23:39 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 02:26:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e544a08ab677f679c3f5b0c74112140e2f0b8d4
Cr-Commit-Position: refs/heads/master@{#434835}

Powered by Google App Engine
This is Rietveld 408576698