Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2546373002: Properly simulate self-closing tags when in "foreign content" mode (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly simulate self-closing tags when in "foreign content" mode When background parsing, a tag that "opens" foreign content mode and had the "self-closing" flag set (<svg/> and <math/>), would place the simulator in foreign content mode without a chance to get out of it. Run the "end tag" steps in this case too, to properly balance the namespace stack. BUG=537642 Committed: https://crrev.com/a6f11c32eb4c9534373b317d470fb9c56a1dfa0e Cr-Commit-Position: refs/heads/master@{#436569}

Patch Set 1 #

Patch Set 2 : Add CORE_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
fs
4 years ago (2016-12-05 14:33:09 UTC) #10
kouhei (in TOK)
lgtm Thanks
4 years ago (2016-12-06 00:59:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546373002/20001
4 years ago (2016-12-06 11:28:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 11:33:01 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 11:35:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6f11c32eb4c9534373b317d470fb9c56a1dfa0e
Cr-Commit-Position: refs/heads/master@{#436569}

Powered by Google App Engine
This is Rietveld 408576698