third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp - Issue 2546373002: Properly simulate self-closing tags when in "foreign content" mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

Issue 2546373002: Properly simulate self-closing tags when in "foreign content" mode (Closed)

Patch Set: Add CORE_EXPORT Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

index cc551e93e6081a4d896c036efc4b67a5920e67a0..17d9757770ceb1d603da3e0cf3158f57010e8c09 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

@@ -158,7 +158,9 @@ HTMLTreeBuilderSimulator::SimulatedToken HTMLTreeBuilderSimulator::simulate(

}

- if (token.type() == HTMLToken::EndTag) {

+ if (token.type() == HTMLToken::EndTag ||

+ (token.selfClosing() && token.type() == HTMLToken::StartTag &&

+ inForeignContent())) {

const String& tagName = token.data();

if ((m_namespaceStack.back() == SVG &&

threadSafeMatch(tagName, SVGNames::svgTag)) ||