Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2546183004: Remove unused linked_ptr inclusion (Closed)

Created:
4 years ago by Sunny
Modified:
4 years ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, msramek+watch_chromium.org, posciak+watch_chromium.org, oka+watch_chromium.org, fukino+watch_chromium.org, markusheintz_, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, samuong+watch_chromium.org, achuith+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, alemate+watch_chromium.org, imcheng+watch_chromium.org, tdresser+watch_chromium.org, jasonroberts+watch_google.com, yamaguchi+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, sync-reviews_chromium.org, tfarina, avayvod+watch_chromium.org, isheriff+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused linked_ptr inclusion TBR=jam@chromium.org BUG=556939 Committed: https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377 Cr-Commit-Position: refs/heads/master@{#437526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M chrome/browser/browsing_data/local_data_container.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_model_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details_history.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_session_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/session_commands_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/guest_view/renderer/guest_view_container_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/login/screens/screen_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/core/browser/about_signin_internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_monster.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/contents_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/core/shadow_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
Sunny
4 years ago (2016-12-07 18:15:48 UTC) #1
dcheng
LGTM, but I'm not an OWNER for these files.
4 years ago (2016-12-07 18:27:13 UTC) #2
Sunny
On 2016/12/07 18:27:13, dcheng wrote: > LGTM, but I'm not an OWNER for these files. ...
4 years ago (2016-12-07 18:31:08 UTC) #3
dcheng
This is OK to TBR, but you should add the other reviewers, update the CL ...
4 years ago (2016-12-07 18:36:48 UTC) #4
commit-bot: I haz the power
COMMIT=false detected. CQ is abandoning the patch.
4 years ago (2016-12-08 05:24:33 UTC) #9
Sunny
On 2016/12/07 18:36:48, dcheng wrote: > This is OK to TBR, but you should add ...
4 years ago (2016-12-08 05:29:32 UTC) #10
Sunny
On 2016/12/07 18:36:48, dcheng wrote: > This is OK to TBR, but you should add ...
4 years ago (2016-12-08 05:35:03 UTC) #11
jam
lgtm
4 years ago (2016-12-08 17:02:48 UTC) #12
dcheng
On 2016/12/08 05:29:32, Sunny wrote: > On 2016/12/07 18:36:48, dcheng wrote: > > This is ...
4 years ago (2016-12-08 22:10:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546183004/1
4 years ago (2016-12-09 09:38:04 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/195824)
4 years ago (2016-12-09 11:12:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546183004/1
4 years ago (2016-12-09 12:56:36 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 13:39:00 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-09 13:40:26 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/090622c5da065ed0fa7c4db26719b7eb58198377
Cr-Commit-Position: refs/heads/master@{#437526}

Powered by Google App Engine
This is Rietveld 408576698