Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2546173003: Fix under-invalidation of frameset on resize (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix under-invalidation of frameset on resize Previously frameset had two problems: 1. (m-54 regression caused by https://codereview.chromium.org/2203933002) LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() returned true for frameset causing no invalidation when a frameset is resized. 2. (Not a regression) frameset should not do incremental invalidation. This didn't cause problem because the raster invalidation rects of the frames cover changed part of the frameset. BUG=669327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 NOTRY=true NOPRESUBMIT=true TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2544743002 Cr-Commit-Position: refs/heads/master@{#435724}

Patch Set 1 #

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546173003/1
4 years ago (2016-12-03 03:37:37 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-12-03 03:37:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546173003/1
4 years ago (2016-12-03 03:38:41 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-03 03:38:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546173003/1
4 years ago (2016-12-03 03:39:34 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 03:40:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698