Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2546093002: [debugger] use abortjs to quit (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Dan Ehrenberg, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] use abortjs to quit --asan test config passes --omit-quit which breaks this test on failure. Committed: https://crrev.com/1f34eb0ab10c46ffe0e91f283e1d399d98df4853 Cr-Commit-Position: refs/heads/master@{#41627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M test/debugger/debug/harmony/async-debug-caught-exception-cases.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
gsathya
4 years ago (2016-12-02 15:36:14 UTC) #5
Dan Ehrenberg
lgtm Are there any other uses of quit() to update?
4 years ago (2016-12-02 21:52:38 UTC) #8
jgruber
lgtm
4 years ago (2016-12-05 07:42:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546093002/1
4 years ago (2016-12-10 03:34:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 03:59:58 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-10 04:00:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f34eb0ab10c46ffe0e91f283e1d399d98df4853
Cr-Commit-Position: refs/heads/master@{#41627}

Powered by Google App Engine
This is Rietveld 408576698