|
|
Chromium Code Reviews|
Created:
4 years ago by nhiroki Modified:
4 years ago Reviewers:
falken CC:
chromium-reviews, shimazu+worker_chromium.org, haraken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Fix cross-thread violations on ObjectProxy
This CL fixes 2 cross-thread violation issues:
1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to
ObjectProxy on the worker thread so that the object proxy can post a task to
the main thread without accessing a pointer to the messaging proxy.
2) This stops InProcessWorkerObjectProxy on the worker thread from accessing
Document on the main thread and removes getExecutionContext().
BUG=667310
Committed: https://crrev.com/a36ee3740ceb393c22500b5ef4e170aafd79c566
Cr-Commit-Position: refs/heads/master@{#437187}
Patch Set 1 #
Messages
Total messages: 57 (52 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Worker: Clean up InProcessWorkerObjectProxy BUG=n/a ========== to ========== Worker: Fix cross-thread violations on InProcessWorkerObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from InProcessWorkerMessagingProxy on the main thread to InProcessWorkerObjectProxy on the worker thread so that the object proxy no longer needs to access the messing proxy |m_messagingProxy| to post a task. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread by removing getExecutionContext(). BUG=n/a ==========
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Worker: Fix cross-thread violations on InProcessWorkerObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from InProcessWorkerMessagingProxy on the main thread to InProcessWorkerObjectProxy on the worker thread so that the object proxy no longer needs to access the messing proxy |m_messagingProxy| to post a task. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread by removing getExecutionContext(). BUG=n/a ========== to ========== Worker: Fix cross-thread violations on InProcessWorkerObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from InProcessWorkerMessagingProxy on the main thread to InProcessWorkerObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a raw pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Patchset #9 (id:160001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Description was changed from ========== Worker: Fix cross-thread violations on InProcessWorkerObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from InProcessWorkerMessagingProxy on the main thread to InProcessWorkerObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a raw pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ========== to ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ==========
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ========== to ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ==========
Patchset #1 (id:120001) has been deleted
Patchset #1 (id:140001) has been deleted
Patchset #1 (id:180001) has been deleted
Patchset #1 (id:200001) has been deleted
Patchset #1 (id:220001) has been deleted
Description was changed from ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=n/a ========== to ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 ==========
Description was changed from ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the messaging proxy without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 ========== to ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the main thread without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 ==========
nhiroki@chromium.org changed reviewers: + falken@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 240001, "attempt_start_ts": 1481173994568010,
"parent_rev": "1625f7dca301abd197df778622a58c62a0682f18", "commit_rev":
"95214ef8329e3ad85f343d8e6b336d1a04e074cc"}
Message was sent while issue was closed.
Committed patchset #1 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the main thread without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 ========== to ========== Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the main thread without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 Committed: https://crrev.com/a36ee3740ceb393c22500b5ef4e170aafd79c566 Cr-Commit-Position: refs/heads/master@{#437187} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a36ee3740ceb393c22500b5ef4e170aafd79c566 Cr-Commit-Position: refs/heads/master@{#437187} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
