Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2546043002: Worker: Fix cross-thread violations on ObjectProxy (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, shimazu+worker_chromium.org, haraken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Fix cross-thread violations on ObjectProxy This CL fixes 2 cross-thread violation issues: 1) This passes ParentFrameTaskRunners from MessagingProxy on the main thread to ObjectProxy on the worker thread so that the object proxy can post a task to the main thread without accessing a pointer to the messaging proxy. 2) This stops InProcessWorkerObjectProxy on the worker thread from accessing Document on the main thread and removes getExecutionContext(). BUG=667310 Committed: https://crrev.com/a36ee3740ceb393c22500b5ef4e170aafd79c566 Cr-Commit-Position: refs/heads/master@{#437187}

Patch Set 1 #

Messages

Total messages: 57 (52 generated)
nhiroki
PTAL, thanks!
4 years ago (2016-12-07 08:34:53 UTC) #48
falken
lgtm
4 years ago (2016-12-08 04:49:41 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546043002/240001
4 years ago (2016-12-08 05:13:36 UTC) #53
commit-bot: I haz the power
Committed patchset #1 (id:240001)
4 years ago (2016-12-08 05:18:47 UTC) #55
commit-bot: I haz the power
4 years ago (2016-12-08 05:20:58 UTC) #57
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a36ee3740ceb393c22500b5ef4e170aafd79c566
Cr-Commit-Position: refs/heads/master@{#437187}

Powered by Google App Engine
This is Rietveld 408576698