third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp - Issue 2546043002: Worker: Fix cross-thread violations on ObjectProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

Issue 2546043002: Worker: Fix cross-thread violations on ObjectProxy (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

index f8e919b7d7d21fb99871afd922a7107ca6c6472f..bb17ac44d430b6f64cde21c9ac90a931b0b53c7d 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

@@ -34,8 +34,8 @@ void evaluateScriptOnWorkletGlobalScope(const String& source,

ThreadedWorkletMessagingProxy::ThreadedWorkletMessagingProxy(

ExecutionContext* executionContext)

: ThreadedMessagingProxyBase(executionContext), m_weakPtrFactory(this) {

- m_workletObjectProxy =

- ThreadedWorkletObjectProxy::create(m_weakPtrFactory.createWeakPtr());

+ m_workletObjectProxy = ThreadedWorkletObjectProxy::create(

+ m_weakPtrFactory.createWeakPtr(), getParentFrameTaskRunners());

}

void ThreadedWorkletMessagingProxy::initialize() {