Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2545983002: DevTools: Use TextPrompt for FilterBar instead of input element (Closed)

Created:
4 years ago by einbinder
Modified:
4 years ago
Reviewers:
dgozman, allada
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use TextPrompt for FilterBar instead of input element BUG=670550 Committed: https://crrev.com/fbb92aa722a4723c69c07de6163c3725b653c290 Cr-Commit-Position: refs/heads/master@{#437134}

Patch Set 1 #

Patch Set 2 : Use textWithCurrentSuggestion #

Messages

Total messages: 18 (10 generated)
einbinder
ptal @allada: Can you verify this has the correct behavior in the network panel?
4 years ago (2016-12-02 03:10:29 UTC) #2
dgozman
lgtm
4 years ago (2016-12-06 20:18:22 UTC) #3
allada
Only thing for me is to have it auto filter while typing into the box.
4 years ago (2016-12-07 00:19:03 UTC) #6
einbinder
On 2016/12/07 at 00:19:03, allada wrote: > Only thing for me is to have it ...
4 years ago (2016-12-07 01:51:53 UTC) #7
allada
lgtm
4 years ago (2016-12-08 00:33:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545983002/20001
4 years ago (2016-12-08 00:34:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 01:57:53 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 02:02:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbb92aa722a4723c69c07de6163c3725b653c290
Cr-Commit-Position: refs/heads/master@{#437134}

Powered by Google App Engine
This is Rietveld 408576698