third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html - Issue 2545983002: DevTools: Use TextPrompt for FilterBar instead of input element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html

Issue 2545983002: DevTools: Use TextPrompt for FilterBar instead of input element (Closed)

Patch Set: Use textWithCurrentSuggestion Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html

index 71805962693c3dc39bdfe93fc56f105008160c23..2dba1356fa5aadc96ec87c954e586e50d936b270 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html

@@ -90,9 +90,8 @@ function test()

function setNetworkLogFilter(value, isRegex)

{

- UI.panels.network._networkLogView._textFilterUI._filterInputElement.value = value;

UI.panels.network._networkLogView._textFilterUI._regexCheckBox.checked = isRegex;

- UI.panels.network._networkLogView._textFilterUI._valueChanged();

+ UI.panels.network._networkLogView._textFilterUI.setValue(value);

UI.panels.network._networkLogView._filterChanged(null); // event not used in this method, so passing null

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js » ('j') | no next file with comments »