Accessing navigation information via webcontents

chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Index: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
index bf1e16092a4558a1f713c3a90582ebee9a49289d..08e6c336d22f285c1cb59ff6970416702137e5bb 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
@@ -1320,18 +1320,21 @@ TEST_F(ResourcePrefetchPredictorTest, SummarizeResponse) {
   url_request_job_factory_.set_response_info(response_info);
 
   GURL url("http://www.google.com/cat.png");
+  GURL emptyUrl;

[ahemery, 2016/12/06 14:31:11]

Just using GURL()

   std::unique_ptr<net::URLRequest> request = CreateURLRequest(
       url, net::MEDIUM, content::RESOURCE_TYPE_IMAGE, 1, 1, true);
   URLRequestSummary summary;
   EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request, &summary));
-  EXPECT_EQ(1, summary.navigation_id.render_process_id);
-  EXPECT_EQ(1, summary.navigation_id.render_frame_id);
-  EXPECT_EQ(url, summary.navigation_id.main_frame_url);
   EXPECT_EQ(url, summary.resource_url);
   EXPECT_EQ(content::RESOURCE_TYPE_IMAGE, summary.resource_type);
   EXPECT_TRUE(summary.was_cached);
   EXPECT_FALSE(summary.has_validators);
   EXPECT_FALSE(summary.always_revalidate);
+
+  // navigation_id elements should be unset by default

[ahemery, 2016/12/05 09:38:45]

Simply reflecting the changes commented in SummarizeResponse. Note: Cannot
directly compare NavigationID's to avoid DCHECK(is_valid) triggering

[alexilin, 2016/12/05 13:20:00]

nit: add period to the end of the comment.
https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_G...

+  EXPECT_EQ(-1, summary.navigation_id.render_process_id);
+  EXPECT_EQ(-1, summary.navigation_id.render_frame_id);
+  EXPECT_EQ(emptyUrl, summary.navigation_id.main_frame_url);
 }
 
 TEST_F(ResourcePrefetchPredictorTest, SummarizeResponseContentType) {