Accessing navigation information via webcontents

chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
 
 #include <iostream>
 #include <memory>
 #include <utility>
 
@@ skipping 1302 matching lines @@
 }
 
 TEST_F(ResourcePrefetchPredictorTest, SummarizeResponse) {
   net::HttpResponseInfo response_info;
   response_info.headers =
       MakeResponseHeaders("HTTP/1.1 200 OK\n\nSome: Headers\n");
   response_info.was_cached = true;
   url_request_job_factory_.set_response_info(response_info);
 
   GURL url("http://www.google.com/cat.png");
+  GURL emptyUrl;

[ahemery, 2016/12/06 14:31:11]

Just using GURL()

   std::unique_ptr<net::URLRequest> request = CreateURLRequest(
       url, net::MEDIUM, content::RESOURCE_TYPE_IMAGE, 1, 1, true);
   URLRequestSummary summary;
   EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request, &summary));
-  EXPECT_EQ(1, summary.navigation_id.render_process_id);
-  EXPECT_EQ(1, summary.navigation_id.render_frame_id);
-  EXPECT_EQ(url, summary.navigation_id.main_frame_url);
   EXPECT_EQ(url, summary.resource_url);
   EXPECT_EQ(content::RESOURCE_TYPE_IMAGE, summary.resource_type);
   EXPECT_TRUE(summary.was_cached);
   EXPECT_FALSE(summary.has_validators);
   EXPECT_FALSE(summary.always_revalidate);
+
+  // navigation_id elements should be unset by default

[ahemery, 2016/12/05 09:38:45]

Simply reflecting the changes commented in SummarizeResponse. Note: Cannot
directly compare NavigationID's to avoid DCHECK(is_valid) triggering

[alexilin, 2016/12/05 13:20:00]

nit: add period to the end of the comment.
https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_G...

+  EXPECT_EQ(-1, summary.navigation_id.render_process_id);
+  EXPECT_EQ(-1, summary.navigation_id.render_frame_id);
+  EXPECT_EQ(emptyUrl, summary.navigation_id.main_frame_url);
 }
 
 TEST_F(ResourcePrefetchPredictorTest, SummarizeResponseContentType) {
   net::HttpResponseInfo response_info;
   response_info.headers = MakeResponseHeaders(
       "HTTP/1.1 200 OK\n\n"
       "Some: Headers\n"
       "Content-Type: image/whatever\n");
   url_request_job_factory_.set_response_info(response_info);
   url_request_job_factory_.set_mime_type("image/png");
@@ skipping 204 matching lines @@
                          net::MEDIUM, false, false);
   predictor_->url_table_cache_->insert(
       std::make_pair(www_google_url.primary_key(), www_google_url));
 
   urls.clear();
   EXPECT_TRUE(predictor_->GetPrefetchData(main_frame_url, &urls));
   EXPECT_THAT(urls, UnorderedElementsAre(GURL(font_url)));
 }
 
 }  // namespace predictors