Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Issue 2545773003: Remove unused code, AstValueFactory::ConcatStrings. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused code, AstValueFactory::ConcatStrings. BUG= Committed: https://crrev.com/0315bfff6b0f85d5d576156d1849ed217a553969 Cr-Commit-Position: refs/heads/master@{#41497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast/ast-value-factory.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
vogelheim
4 years ago (2016-12-02 10:49:39 UTC) #4
marja
lgtm (I had to dig up where this code originated from, since I was pretty ...
4 years ago (2016-12-02 11:48:59 UTC) #7
vogelheim
On 2016/12/02 11:48:59, marja wrote: > lgtm > > (I had to dig up where ...
4 years ago (2016-12-02 12:17:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545773003/1
4 years ago (2016-12-05 17:34:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:00:31 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 18:00:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0315bfff6b0f85d5d576156d1849ed217a553969
Cr-Commit-Position: refs/heads/master@{#41497}

Powered by Google App Engine
This is Rietveld 408576698