Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: test/cctest/test-ast.cc

Issue 2545773003: Remove unused code, AstValueFactory::ConcatStrings. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast-value-factory.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 const int kElements = 100; 52 const int kElements = 100;
53 for (int i = 0; i < kElements; i++) { 53 for (int i = 0; i < kElements; i++) {
54 list->Add(node); 54 list->Add(node);
55 } 55 }
56 CHECK_EQ(1 + kElements, list->length()); 56 CHECK_EQ(1 + kElements, list->length());
57 57
58 list->Clear(); 58 list->Clear();
59 CHECK_EQ(0, list->length()); 59 CHECK_EQ(0, list->length());
60 delete list; 60 delete list;
61 } 61 }
62
63 TEST(ConcatStrings) {
64 v8::internal::AccountingAllocator allocator;
65 Zone zone(&allocator, ZONE_NAME);
66 AstValueFactory value_factory(&zone, 0);
67
68 const AstRawString* one_byte = value_factory.GetOneByteString("a");
69
70 uint16_t two_byte_buffer[] = {
71 0x3b1,
72 };
73 const AstRawString* two_byte = value_factory.GetTwoByteString(
74 Vector<const uint16_t>(two_byte_buffer, 1));
75
76 const AstRawString* expectation = value_factory.GetOneByteString("aa");
77 const AstRawString* result = value_factory.ConcatStrings(one_byte, one_byte);
78 CHECK(result->is_one_byte());
79 CHECK_EQ(expectation, result);
80
81 uint16_t expectation_buffer_one_two[] = {'a', 0x3b1};
82 expectation = value_factory.GetTwoByteString(
83 Vector<const uint16_t>(expectation_buffer_one_two, 2));
84 result = value_factory.ConcatStrings(one_byte, two_byte);
85 CHECK(!result->is_one_byte());
86 CHECK_EQ(expectation, result);
87
88 uint16_t expectation_buffer_two_one[] = {0x3b1, 'a'};
89 expectation = value_factory.GetTwoByteString(
90 Vector<const uint16_t>(expectation_buffer_two_one, 2));
91 result = value_factory.ConcatStrings(two_byte, one_byte);
92 CHECK(!result->is_one_byte());
93 CHECK_EQ(expectation, result);
94
95 uint16_t expectation_buffer_two_two[] = {0x3b1, 0x3b1};
96 expectation = value_factory.GetTwoByteString(
97 Vector<const uint16_t>(expectation_buffer_two_two, 2));
98 result = value_factory.ConcatStrings(two_byte, two_byte);
99 CHECK(!result->is_one_byte());
100 CHECK_EQ(expectation, result);
101 }
OLDNEW
« no previous file with comments | « src/ast/ast-value-factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698