Source/core/rendering/InlineBox.h - Issue 254573006: Avoid markDirty when removing out-of-flow line boxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineBox.h

Issue 254573006: Avoid markDirty when removing out-of-flow line boxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dynamic/static-to-relative-with-absolute-child-expected.html ('k') | Source/core/rendering/InlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/InlineBox.h

diff --git a/Source/core/rendering/InlineBox.h b/Source/core/rendering/InlineBox.h

index 8f2a4ff153eaafcd7bf529e83a3c308729b8015f..2aadc90766e5ff271679e6dc3a8868cca94022dd 100644

--- a/Source/core/rendering/InlineBox.h

+++ b/Source/core/rendering/InlineBox.h

@@ -30,6 +30,8 @@ class HitTestRequest;

class HitTestResult;

class RootInlineBox;

+enum MarkLineBoxes { MarkLineBoxesDirty, DontMarkLineBoxes };

// InlineBox represents a rectangle that occurs on a line. It corresponds to

// some RenderObject (i.e., it represents a portion of that RenderObject).

class InlineBox {

@@ -147,7 +149,7 @@ public:

void setFirstLineStyleBit(bool firstLine) { m_bitfields.setFirstLine(firstLine); }

bool isFirstLineStyle() const { return m_bitfields.firstLine(); }

- void remove();

+ void remove(MarkLineBoxes = MarkLineBoxesDirty);

InlineBox* nextOnLine() const { return m_next; }

InlineBox* prevOnLine() const { return m_prev; }