Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2545653003: Make more concrete stream classes private to .cpp files (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make more concrete stream classes private to .cpp files Committed: https://pdfium.googlesource.com/pdfium/+/bea049784abf7c32d0b9758fc77d0e601d5c232b

Patch Set 1 #

Total comments: 12

Patch Set 2 : namespace, private not protected #

Total comments: 2

Patch Set 3 : {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -162 lines) Patch
M core/fxcrt/extension.h View 1 chunk +0 lines, -80 lines 0 comments Download
M core/fxcrt/fx_extension.cpp View 1 2 3 chunks +123 lines, -43 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 chunks +43 lines, -25 lines 0 comments Download
M fpdfsdk/fsdk_define.h View 1 chunk +3 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Tom Sepez
npm, ready for review.
4 years ago (2016-12-01 21:07:25 UTC) #4
npm
https://codereview.chromium.org/2545653003/diff/1/core/fxcrt/fx_extension.cpp File core/fxcrt/fx_extension.cpp (right): https://codereview.chromium.org/2545653003/diff/1/core/fxcrt/fx_extension.cpp#newcode37 core/fxcrt/fx_extension.cpp:37: protected: Can this be private? https://codereview.chromium.org/2545653003/diff/1/core/fxcrt/fx_extension.cpp#newcode88 core/fxcrt/fx_extension.cpp:88: protected: Ditto ...
4 years ago (2016-12-01 21:21:49 UTC) #5
Tom Sepez
https://codereview.chromium.org/2545653003/diff/1/core/fxcrt/fx_extension.cpp File core/fxcrt/fx_extension.cpp (right): https://codereview.chromium.org/2545653003/diff/1/core/fxcrt/fx_extension.cpp#newcode37 core/fxcrt/fx_extension.cpp:37: protected: On 2016/12/01 21:21:49, npm wrote: > Can this ...
4 years ago (2016-12-01 21:33:45 UTC) #8
npm
lgtm https://codereview.chromium.org/2545653003/diff/20001/core/fxcrt/fx_extension.cpp File core/fxcrt/fx_extension.cpp (right): https://codereview.chromium.org/2545653003/diff/20001/core/fxcrt/fx_extension.cpp#newcode106 core/fxcrt/fx_extension.cpp:106: if (!nCount) { Nit: no {}
4 years ago (2016-12-01 21:42:21 UTC) #9
Tom Sepez
https://codereview.chromium.org/2545653003/diff/20001/core/fxcrt/fx_extension.cpp File core/fxcrt/fx_extension.cpp (right): https://codereview.chromium.org/2545653003/diff/20001/core/fxcrt/fx_extension.cpp#newcode106 core/fxcrt/fx_extension.cpp:106: if (!nCount) { On 2016/12/01 21:42:20, npm wrote: > ...
4 years ago (2016-12-01 21:43:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545653003/40001
4 years ago (2016-12-01 21:44:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 21:54:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/bea049784abf7c32d0b9758fc77d0e601d5c...

Powered by Google App Engine
This is Rietveld 408576698