Make more concrete stream classes private to .cpp files

fpdfsdk/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdfview.h"
 
 #include <memory>
 #include <utility>
@@ skipping 228 matching lines @@
 }
 
 bool CFPDF_FileStream::Flush() {
   if (!m_pFS || !m_pFS->Flush)
     return true;
 
   return m_pFS->Flush(m_pFS->clientData) == 0;
 }
 #endif  // PDF_ENABLE_XFA
 
+class CPDF_CustomAccess final : public IFX_SeekableReadStream {

[npm, 2016/12/01 21:21:49]

Can this go inside namespace?

[Tom Sepez, 2016/12/01 21:33:45]

Done.

+ public:
+  explicit CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess);
+  ~CPDF_CustomAccess() override {}
+
+  // IFX_SeekableReadStream
+  FX_FILESIZE GetSize() override;
+  void Release() override;
+  bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override;
+
+ private:
+  FPDF_FILEACCESS m_FileAccess;
+};
+
+IFX_SeekableReadStream* MakeSeekableReadStream(FPDF_FILEACCESS* pFileAccess) {
+  return new CPDF_CustomAccess(pFileAccess);
+}
+
 CPDF_CustomAccess::CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess)
     : m_FileAccess(*pFileAccess) {}
 
 FX_FILESIZE CPDF_CustomAccess::GetSize() {
   return m_FileAccess.m_FileLen;
 }
 
 void CPDF_CustomAccess::Release() {
   delete this;
 }
@@ skipping 918 matching lines @@
   if (!buffer) {
     *buflen = len;
   } else if (len <= *buflen) {
     memcpy(buffer, utf16Name.c_str(), len);
     *buflen = len;
   } else {
     *buflen = -1;
   }
   return (FPDF_DEST)pDestObj;
 }