Issue 2545613002: [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2545613002: [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} (Closed)

Created:
4 years ago by kozy

Modified:
4 years ago

Reviewers:
dgozman

CC:
chromium-reviews, devtools-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
inspector_protocol

Visibility:
Public.

[inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} Dispatcher can be destroyed during command processing. BUG=chromium:668358 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol715b83a3cfb45ce6c67b6c6fdd2c16391b5db896

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	templates/TypeBuilder_cpp.template	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

kozy

4 years ago (2016-12-01 00:36:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 (presubmit successful).