Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6156)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2545593003: Additional heuristic user interaction attribution for page load metrics (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 79531b63b93b3795f5efb9b7c05d23bcd1a06056..41ae2b1ed733729b4d326ec88b26a2e246936304 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -333,7 +333,10 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
timing.first_contentful_paint.value());
}
- if (info.user_initiated) {
+ // TODO(bmcquade): consider adding a histogram that uses
+ // UserInputInfo.user_input_event.
+ if (info.user_initiated_info.browser_initiated ||
+ info.user_initiated_info.user_gesture) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintUserInitiated,
timing.first_contentful_paint.value());
}
@@ -351,7 +354,10 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(
internal::kHistogramLoadTypeFirstContentfulPaintReload,
timing.first_contentful_paint.value());
- if (info.user_initiated) {
+ // TODO(bmcquade): consider adding a histogram that uses
+ // UserInputInfo.user_input_event.
+ if (info.user_initiated_info.browser_initiated ||
+ info.user_initiated_info.user_gesture) {
PAGE_LOAD_HISTOGRAM(
internal::kHistogramLoadTypeFirstContentfulPaintReloadByGesture,
timing.first_contentful_paint.value());

Powered by Google App Engine
This is Rietveld 408576698