Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Issue 2545593003: Additional heuristic user interaction attribution for page load metrics (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 1eea3ad5b4ea5743353664bd358cc0a26a4b5670..b75118150310c1a805e3284d6b235ae119564e9d 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -94,7 +94,6 @@ TEST_F(AbortsPageLoadMetricsObserverTest, NewNavigationBeforePaint) {
NavigateAndCommit(GURL("https://www.example.com"));
histogram_tester().ExpectTotalCount(
internal::kHistogramAbortNewNavigationBeforePaint, 1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, ReloadBeforePaint) {
@@ -105,7 +104,6 @@ TEST_F(AbortsPageLoadMetricsObserverTest, ReloadBeforePaint) {
ui::PAGE_TRANSITION_RELOAD);
histogram_tester().ExpectTotalCount(
internal::kHistogramAbortReloadBeforePaint, 1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, ForwardBackBeforePaint) {
@@ -118,7 +116,6 @@ TEST_F(AbortsPageLoadMetricsObserverTest, ForwardBackBeforePaint) {
ui::PAGE_TRANSITION_FORWARD_BACK));
histogram_tester().ExpectTotalCount(
internal::kHistogramAbortForwardBackBeforePaint, 1);
- EXPECT_EQ(1, CountTotalAbortMetricsRecorded());
}
TEST_F(AbortsPageLoadMetricsObserverTest, BackgroundBeforePaint) {

Powered by Google App Engine
This is Rietveld 408576698