Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2545553007: Add support for generating lints when using the new driver (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for generating lints when using the new driver R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b81564b6234a1173d3ff9887bd258ceff034b508

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -24 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 7 chunks +39 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +30 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/status.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Brian Wilkerson
4 years ago (2016-12-02 22:28:58 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart File pkg/analysis_server/test/analysis/notification_errors_test.dart (right): https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart#newcode166 pkg/analysis_server/test/analysis/notification_errors_test.dart:166: // notifications. We might get error notifications, just ...
4 years ago (2016-12-02 22:36:58 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart File pkg/analysis_server/test/analysis/notification_errors_test.dart (right): https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart#newcode166 pkg/analysis_server/test/analysis/notification_errors_test.dart:166: // notifications. Is there a way to wait until ...
4 years ago (2016-12-02 22:51:30 UTC) #4
scheglov
https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart File pkg/analysis_server/test/analysis/notification_errors_test.dart (right): https://codereview.chromium.org/2545553007/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart#newcode166 pkg/analysis_server/test/analysis/notification_errors_test.dart:166: // notifications. On 2016/12/02 22:51:30, Brian Wilkerson wrote: > ...
4 years ago (2016-12-02 22:52:31 UTC) #5
Brian Wilkerson
PTAL Two of the tests now pass by pumping the event queue, but one still ...
4 years ago (2016-12-02 23:05:46 UTC) #6
scheglov
LGTM The remaining failures are actual bugs with the new driver. We don't handle unresolved ...
4 years ago (2016-12-02 23:12:18 UTC) #7
Brian Wilkerson
4 years ago (2016-12-03 15:25:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b81564b6234a1173d3ff9887bd258ceff034b508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698