Add support for generating lints when using the new driver

pkg/analysis_server/test/analysis/notification_errors_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification_errors;
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/constants.dart';
+import 'package:analysis_server/src/context_manager.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
+import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/services/lint.dart';
 import 'package:linter/src/linter.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../analysis_abstract.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(NotificationErrorsTest);
+    defineReflectiveTests(NotificationErrorsTest_Driver);
   });
 }
 
 @reflectiveTest
-class NotificationErrorsTest extends AbstractAnalysisTest {
+class AbstractNotificationErrorsTest extends AbstractAnalysisTest {
   Map<String, List<AnalysisError>> filesErrors = {};
 
   void processNotification(Notification notification) {
     if (notification.event == ANALYSIS_ERRORS) {
       var decoded = new AnalysisErrorsParams.fromNotification(notification);
       filesErrors[decoded.file] = decoded.errors;
     }
   }
 
   @override
@@ skipping 32 matching lines @@
     - $camelCaseTypesLintName
 ''');
 
     addTestFile('class a { }');
 
     Request request =
         new AnalysisSetAnalysisRootsParams([projectPath], []).toRequest('0');
     handleSuccessfulRequest(request);
 
     await waitForTasksFinished();
-    AnalysisContext testContext = server.getContainingContext(testFile);
-    List<Linter> lints = getLints(testContext);
+    List<Linter> lints;
+    if (enableNewAnalysisDriver) {
+      AnalysisDriver testDriver = (server.contextManager as ContextManagerImpl)
+          .getContextInfoFor(resourceProvider.getFolder(projectPath))
+          .analysisDriver;
+      lints = testDriver.analysisOptions.lintRules;
+    } else {
+      AnalysisContext testContext = server.getContainingContext(testFile);
+      lints = getLints(testContext);
+    }
     // Registry should only contain single lint rule.
     expect(lints, hasLength(1));
     LintRule lint = lints.first as LintRule;
     expect(lint.name, camelCaseTypesLintName);
     // Verify lint error result.
     List<AnalysisError> errors = filesErrors[testFile];
     expect(errors, hasLength(1));
     AnalysisError error = errors[0];
     expect(error.location.file, '/project/bin/test.dart');
     expect(error.severity, AnalysisErrorSeverity.INFO);
@@ skipping 38 matching lines @@
 }
 ''');
     await waitForTasksFinished();
     List<AnalysisError> errors = filesErrors[testFile];
     expect(errors, hasLength(1));
     AnalysisError error = errors[0];
     expect(error.severity, AnalysisErrorSeverity.WARNING);
     expect(error.type, AnalysisErrorType.STATIC_WARNING);
   }
 }
+
+@reflectiveTest
+class NotificationErrorsTest extends AbstractNotificationErrorsTest {}
+
+@reflectiveTest
+class NotificationErrorsTest_Driver extends AbstractNotificationErrorsTest {
+  @override
+  void setUp() {
+    enableNewAnalysisDriver = true;
+    generateSummaryFiles = true;
+    super.setUp();
+  }
+
+  @failingTest
+  @override
+  test_importError() {
+    // The overridden test is failing because we're not getting any error
+    // notifications.

[scheglov, 2016/12/02 22:36:58]

We might get error notifications, just too late for the test :-)
It is possible that "await waitForTasksFinished();" is done, but the code:
      _runDelayed(() {
        new_sendErrorNotification(analysisServer, result);
      });
in ServerContextManagerCallbacks.addAnalysisDriver() is not run yet.

[Brian Wilkerson, 2016/12/02 22:51:30]

Is there a way to wait until all communications from the server have been
received?

[scheglov, 2016/12/02 22:52:31]

I don't know it.

+    return super.test_importError();
+  }
+
+  @failingTest
+  @override
+  test_ParserError() {
+    // The overridden test is failing because we're not getting any error
+    // notifications.
+    return super.test_ParserError();
+  }
+
+  @failingTest
+  @override
+  test_StaticWarning() {
+    // The overridden test is failing because we're not getting any error
+    // notifications.
+    return super.test_StaticWarning();
+  }
+}