Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2545523007: Revert of discardable_memory: Using mojo IPC to replace Chrome IPC (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of discardable_memory: Using mojo IPC to replace Chrome IPC (patchset #23 id:490001 of https://codereview.chromium.org/2485623002/ ) Reason for revert: Causing some failures. Example: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac Original issue's description: > discardable_memory: Using mojo IPC to replace Chrome IPC > > It also moves ClientDiscardableSharedMemoryManager from ChildThreadImpl > to RenderThreadImpl and PpapiThread > > BUG=654678 > > Committed: https://crrev.com/a083f971261bcccc53b64e40c911435857ce3bfd > Cr-Commit-Position: refs/heads/master@{#435969} TBR=reveman@chromium.org,avi@chromium.org,dcheng@chromium.org,yzshen@chromium.org,sky@chromium.org,penghuang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654678 Committed: https://crrev.com/23eeee43e2ba326106d915c5023335824a65d8d0 Cr-Commit-Position: refs/heads/master@{#435980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -460 lines) Patch
D components/discardable_memory/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M components/discardable_memory/client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/discardable_memory/client/client_discardable_shared_memory_manager.h View 4 chunks +19 lines, -24 lines 0 comments Download
M components/discardable_memory/client/client_discardable_shared_memory_manager.cc View 9 chunks +50 lines, -121 lines 0 comments Download
M components/discardable_memory/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/discardable_memory/common/discardable_shared_memory_id.h View 1 chunk +17 lines, -0 lines 0 comments Download
D components/discardable_memory/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D components/discardable_memory/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/discardable_memory/public/interfaces/discardable_shared_memory_manager.mojom View 1 chunk +0 lines, -16 lines 0 comments Download
M components/discardable_memory/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/discardable_memory/service/discardable_shared_memory_manager.h View 5 chunks +17 lines, -18 lines 0 comments Download
M components/discardable_memory/service/discardable_shared_memory_manager.cc View 9 chunks +23 lines, -76 lines 0 comments Download
M components/discardable_memory/service/discardable_shared_memory_manager_unittest.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +46 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.h View 8 chunks +22 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.cc View 6 chunks +42 lines, -2 lines 0 comments Download
A content/child/child_thread_impl_browsertest.cc View 1 chunk +130 lines, -0 lines 0 comments Download
M content/common/child_process_messages.h View 2 chunks +14 lines, -0 lines 0 comments Download
M content/common/in_process_child_thread_params.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +0 lines, -102 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of discardable_memory: Using mojo IPC to replace Chrome IPC
4 years ago (2016-12-02 18:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545523007/1
4 years ago (2016-12-02 18:19:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 18:21:04 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 18:22:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23eeee43e2ba326106d915c5023335824a65d8d0
Cr-Commit-Position: refs/heads/master@{#435980}

Powered by Google App Engine
This is Rietveld 408576698