Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25453008: [Android WebView] Disable WebRTC. (Closed)

Created:
7 years, 2 months ago by benm (inactive)
Modified:
7 years, 2 months ago
Reviewers:
joth
CC:
chromium-reviews, android-webview-reviews_chromium.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android WebView] Disable WebRTC. Android WebView compiles out WebRTC, so we should disable runtime interfaces too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
android_webview/lib/main/aw_main_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benm (inactive)
7 years, 2 months ago (2013-10-04 17:36:00 UTC) #1
joth
lgtm +rbyers FYI you'll have to rebase your patch I expect
7 years, 2 months ago (2013-10-04 17:43:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/25453008/1
7 years, 2 months ago (2013-10-04 17:44:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=86098
7 years, 2 months ago (2013-10-05 03:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/25453008/1
7 years, 2 months ago (2013-10-05 09:05:57 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 2 months ago (2013-10-05 17:56:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/25453008/1
7 years, 2 months ago (2013-10-05 17:56:57 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-05 23:38:48 UTC) #8
Message was sent while issue was closed. 
Change committed as 227215

Powered by Google App Engine
This is Rietveld 408576698