Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2545053002: Add gcc toolchain for arm64/linux (Closed)

Created:
4 years ago by Riku Voipio
Modified:
4 years ago
Reviewers:
Dirk Pranke, brettw, scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gcc toolchain for arm64/linux This is needed for Chromium builds in debian/arm64 and matches how arm, x86 and x86_64 also have both clang and gcc toolchains available. R=brettw@chromium.org, dpranke@chromium.org, scottmg@chromium.org Committed: https://crrev.com/62c17901df9489112816380771666f4e6857cd59 Cr-Commit-Position: refs/heads/master@{#436267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/toolchain/linux/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Riku Voipio
PTAL
4 years ago (2016-12-02 13:58:14 UTC) #1
Dirk Pranke
lgtm
4 years ago (2016-12-02 23:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545053002/1
4 years ago (2016-12-05 12:31:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 12:35:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 12:38:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62c17901df9489112816380771666f4e6857cd59
Cr-Commit-Position: refs/heads/master@{#436267}

Powered by Google App Engine
This is Rietveld 408576698