Avoid enabling accessibility for WebContents that are never shown

Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f8a3104f8848afd8a60e10f9f51c6b108bcbf62d
Cr-Commit-Position: refs/heads/master@{#436110}

[dmazzoni, 2016-12-02 06:05:14]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2016-12-02 06:17:55]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 06:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 07:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:12:51]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-12-02 16:19:08]

Description was changed from

==========
Don't show RenderWidgetHostViews with empty viewports in chrome://accessibility

This successfully hides extension background pages but otherwise shows all
tabs and other views. Let's try this and replace it with something

BUG=365370
==========

to

==========
Don't show RenderWidgetHostViews with empty viewports in chrome://accessibility

This successfully hides extension background pages but otherwise shows all
tabs and other views. Let's try this and replace it with something

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2016-12-02 16:20:01]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 16:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-12-02 16:23:28]

Description was changed from

==========
Don't show RenderWidgetHostViews with empty viewports in chrome://accessibility

This successfully hides extension background pages but otherwise shows all
tabs and other views. Let's try this and replace it with something

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2016-12-02 16:23:29]

dmazzoni@chromium.org changed reviewers:
+ nasko@chromium.org

[aboxhall, 2016-12-02 17:13:04]

lgtm

[commit-bot: I haz the power, 2016-12-02 17:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:47:08]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-12-02 21:52:14]

LGTM with a nit.

https://codereview.chromium.org/2544993002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2544993002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:950: // visible, like
extension background pages.
nit: Technically, this code is in content/, which doesn't know about extensions.

[dmazzoni, 2016-12-02 22:19:24]

https://codereview.chromium.org/2544993002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2544993002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:950: // visible, like
extension background pages.
On 2016/12/02 21:52:14, nasko wrote:
> nit: Technically, this code is in content/, which doesn't know about
extensions.

Sounds good, I'll reword to say just "background" pages.
As far as I can tell all of the classes that return true
are for some sort of background page.

[dmazzoni, 2016-12-02 22:23:56]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-12-02 22:23:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2544993002/#ps40001
(title: "Get rid of 'extension' from content code")

[commit-bot: I haz the power, 2016-12-02 22:24:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:52:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480717436006100,
"parent_rev": "1f353ab815eda97835f650876e87c0ab04219548", "commit_rev":
"1fe3ba08153edb08278b9c04257317a1f66b2835"}

[commit-bot: I haz the power, 2016-12-03 00:52:46]

Description was changed from

==========
Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-12-03 00:52:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-03 00:54:03]

Description was changed from

==========
Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Avoid enabling accessibility for WebContents that are never shown

If WebContentsImpl::IsNeverShown() is true, like for an extension background
page, then there's never a reason to enable accessibility. Update
WebContentsImpl::SetAccessibilityMode to check for this, and also
update the UI page for chrome://accessibility to avoid exposing
such views.

BUG=365370
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f8a3104f8848afd8a60e10f9f51c6b108bcbf62d
Cr-Commit-Position: refs/heads/master@{#436110}
==========

[commit-bot: I haz the power, 2016-12-03 00:54:04]

Patchset 3 (id:??) landed as
https://crrev.com/f8a3104f8848afd8a60e10f9f51c6b108bcbf62d
Cr-Commit-Position: refs/heads/master@{#436110}