Avoid enabling accessibility for WebContents that are never shown

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 188 matching lines @@
   if (!host)
     return false;
 
   for (FrameTreeNode* node : tree->Nodes()) {
     if (node->current_frame_host()->GetRenderWidgetHost() == host)
       return true;
   }
   return false;
 }
 
-void SetAccessibilityModeOnFrame(AccessibilityMode mode,
-                                 RenderFrameHost* frame_host) {
-  static_cast<RenderFrameHostImpl*>(frame_host)->SetAccessibilityMode(mode);
+void UpdateAccessibilityModeOnFrame(RenderFrameHost* frame_host) {
+  static_cast<RenderFrameHostImpl*>(frame_host)->UpdateAccessibilityMode();
 }
 
 void ResetAccessibility(RenderFrameHost* rfh) {
   static_cast<RenderFrameHostImpl*>(rfh)->AccessibilityReset();
 }
 
 using AXTreeSnapshotCallback =
       base::Callback<void(const ui::AXTreeUpdate&)>;
 
 // Helper class used by WebContentsImpl::RequestAXTreeSnapshot.
@@ skipping 718 matching lines @@
 }
 
 SkColor WebContentsImpl::GetThemeColor() const {
   return theme_color_;
 }
 
 void WebContentsImpl::SetAccessibilityMode(AccessibilityMode mode) {
   if (mode == accessibility_mode_)
     return;
 
+  // Don't allow accessibility to be enabled for WebContents that are never
+  // visible, like background pages.
+  if (IsNeverVisible())
+    return;
+
   accessibility_mode_ = mode;
 
   for (FrameTreeNode* node : frame_tree_.Nodes()) {
-    SetAccessibilityModeOnFrame(mode, node->current_frame_host());
+    UpdateAccessibilityModeOnFrame(node->current_frame_host());
     RenderFrameHost* pending_frame_host =
         node->render_manager()->pending_frame_host();
     if (pending_frame_host)
-      SetAccessibilityModeOnFrame(mode, pending_frame_host);
+      UpdateAccessibilityModeOnFrame(pending_frame_host);
   }
 }
 
 void WebContentsImpl::AddAccessibilityMode(AccessibilityMode mode) {
   SetAccessibilityMode(AddAccessibilityModeTo(accessibility_mode_, mode));
 }
 
 void WebContentsImpl::RemoveAccessibilityMode(AccessibilityMode mode) {
   SetAccessibilityMode(RemoveAccessibilityModeFrom(accessibility_mode_, mode));
 }
@@ skipping 3090 matching lines @@
     it->second->OnRequestForFrame(render_frame_host, std::move(handle));
 }
 
 const GURL& WebContentsImpl::GetMainFrameLastCommittedURL() const {
   return GetLastCommittedURL();
 }
 
 void WebContentsImpl::RenderFrameCreated(RenderFrameHost* render_frame_host) {
   for (auto& observer : observers_)
     observer.RenderFrameCreated(render_frame_host);
-  SetAccessibilityModeOnFrame(accessibility_mode_, render_frame_host);
+  UpdateAccessibilityModeOnFrame(render_frame_host);
 
   if (!render_frame_host->IsRenderFrameLive() || render_frame_host->GetParent())
     return;
 
   NavigationEntry* entry = controller_.GetPendingEntry();
   if (entry && entry->IsViewSourceMode()) {
     // Put the renderer in view source mode.
     render_frame_host->Send(
         new FrameMsg_EnableViewSourceMode(render_frame_host->GetRoutingID()));
   }
@@ skipping 1202 matching lines @@
   dialog_manager_ = dialog_manager;
 }
 
 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
   auto it = binding_sets_.find(interface_name);
   if (it != binding_sets_.end())
     binding_sets_.erase(it);
 }
 
 }  // namespace content