Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2544963002: Remove links to old build instructions. (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove links to old build instructions. It looks like the new instructions are reasonably good, so I think we can remove the old ones now. R=thakis@chromium.org BUG=670518 Committed: https://crrev.com/27ea3ce48ed67b758957d09c822af573796049c3 Cr-Commit-Position: refs/heads/master@{#435817}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add prereqs page back in for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -910 lines) Patch
M docs/android_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download
M docs/ios_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download
M docs/linux_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download
M docs/mac_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download
D docs/old_android_build_instructions.md View 1 chunk +0 lines, -312 lines 0 comments Download
D docs/old_ios_build_instructions.md View 1 chunk +0 lines, -107 lines 0 comments Download
D docs/old_linux_build_instructions.md View 1 chunk +0 lines, -161 lines 0 comments Download
D docs/old_mac_build_instructions.md View 1 chunk +0 lines, -209 lines 0 comments Download
D docs/old_windows_build_instructions.md View 1 chunk +0 lines, -111 lines 0 comments Download
M docs/windows_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Nico
lgtm, thanks! https://codereview.chromium.org/2544963002/diff/1/docs/linux_build_instructions_prerequisites.md File docs/linux_build_instructions_prerequisites.md (left): https://codereview.chromium.org/2544963002/diff/1/docs/linux_build_instructions_prerequisites.md#oldcode6 docs/linux_build_instructions_prerequisites.md:6: This file will be deleted in the ...
4 years ago (2016-12-02 00:57:49 UTC) #1
Dirk Pranke
https://codereview.chromium.org/2544963002/diff/1/docs/linux_build_instructions_prerequisites.md File docs/linux_build_instructions_prerequisites.md (left): https://codereview.chromium.org/2544963002/diff/1/docs/linux_build_instructions_prerequisites.md#oldcode6 docs/linux_build_instructions_prerequisites.md:6: This file will be deleted in the future, please ...
4 years ago (2016-12-02 01:32:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544963002/20001
4 years ago (2016-12-02 01:33:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 01:46:41 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 01:49:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27ea3ce48ed67b758957d09c822af573796049c3
Cr-Commit-Position: refs/heads/master@{#435817}

Powered by Google App Engine
This is Rietveld 408576698