Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2544793004: More edits to the linux build instructions. (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More edits to the linux build instructions. This change folds the notes on building on the different Linux distros into the main Linux build instructions. It also moves the "faster builds" information into the same page, adds one note for Debian Android builds. R=thomasanderson@chromium.org BUG=670518 Committed: https://crrev.com/2989a785779298a49bc6024ec421c92884e181d7 Cr-Commit-Position: refs/heads/master@{#435835}

Patch Set 1 #

Total comments: 6

Patch Set 2 : tweak debian, gentoo instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -298 lines) Patch
M docs/android_build_instructions.md View 1 chunk +4 lines, -0 lines 0 comments Download
D docs/linux_arch_build_instructions.md View 1 chunk +0 lines, -23 lines 0 comments Download
M docs/linux_build_instructions.md View 1 3 chunks +292 lines, -10 lines 0 comments Download
D docs/linux_debian_build_instructions.md View 1 chunk +0 lines, -12 lines 0 comments Download
D docs/linux_faster_builds.md View 1 chunk +0 lines, -125 lines 0 comments Download
D docs/linux_fedora_build_instructions.md View 1 chunk +0 lines, -27 lines 0 comments Download
D docs/linux_mandriva_build_instructions.md View 1 chunk +0 lines, -22 lines 0 comments Download
D docs/linux_open_suse_build_instructions.md View 1 chunk +0 lines, -79 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
Dirk Pranke
4 years ago (2016-12-02 01:27:23 UTC) #1
Tom (Use chromium acct)
https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md#newcode102 docs/android_build_instructions.md:102: If you're running Debian, you'll also need to install ...
4 years ago (2016-12-02 01:42:38 UTC) #3
Dirk Pranke
https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md#newcode102 docs/android_build_instructions.md:102: If you're running Debian, you'll also need to install ...
4 years ago (2016-12-02 01:56:45 UTC) #4
Tom (Use chromium acct)
https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2544793004/diff/1/docs/android_build_instructions.md#newcode102 docs/android_build_instructions.md:102: If you're running Debian, you'll also need to install ...
4 years ago (2016-12-02 02:09:45 UTC) #5
Dirk Pranke
On 2016/12/02 02:09:45, Tom Anderson wrote: > https://codereview.chromium.org/2544793004/diff/1/docs/linux_build_instructions.md#newcode350 > docs/linux_build_instructions.md:350: You may need to update ...
4 years ago (2016-12-02 02:20:01 UTC) #6
Dirk Pranke
Updated. Please take another look?
4 years ago (2016-12-02 02:35:19 UTC) #7
Tom (Use chromium acct)
thanks this lgtm
4 years ago (2016-12-02 02:40:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544793004/20001
4 years ago (2016-12-02 02:45:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 02:57:41 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-02 03:01:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2989a785779298a49bc6024ec421c92884e181d7
Cr-Commit-Position: refs/heads/master@{#435835}

Powered by Google App Engine
This is Rietveld 408576698