content: Some code cleanup related to shared memory allocation.

content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500
Committed: https://crrev.com/ee3ff1ffb2acc57ffe1668c603d79debcc463b8c
Cr-Commit-Position: refs/heads/master@{#437463}

[sadrul, 2016-12-02 00:40:36]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 00:41:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-02 00:41:45]

sadrul@chromium.org changed reviewers:
+ nasko@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:35:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:35:59]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-12-02 19:58:08]

LGTM with a question.

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:733: *out_of_memory = true;
Do we care to disambiguate an out of memory condition (this branch) vs the
failure to unwrap (the next if condition)? Seems like only consumer is
child_shared_bitmap_manager.cc.

[sadrul, 2016-12-08 03:27:52]

sadrul@chromium.org changed reviewers:
+ erikchen@chromium.org

[sadrul, 2016-12-08 03:27:53]

+erikchen@ to confirm

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:733: *out_of_memory = true;
On 2016/12/02 19:58:08, nasko (very slow til Dec 13th) wrote:
> Do we care to disambiguate an out of memory condition (this branch) vs the
> failure to unwrap (the next if condition)? Seems like only consumer is
> child_shared_bitmap_manager.cc.

Looks like the original failure mode during teardown no longer applies
(https://codereview.chromium.org/2010563004 is the CL that added this).
erikchen@: can you please confirm? In which case, we wouldn't need the
|out_of_memory| param. A null return value would imply OOM.

[erikchen, 2016-12-08 03:36:02]

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:733: *out_of_memory = true;
On 2016/12/08 03:27:52, sadrul wrote:
> On 2016/12/02 19:58:08, nasko (very slow til Dec 13th) wrote:
> > Do we care to disambiguate an out of memory condition (this branch) vs the
> > failure to unwrap (the next if condition)? Seems like only consumer is
> > child_shared_bitmap_manager.cc.
> 
> Looks like the original failure mode during teardown no longer applies
> (https://codereview.chromium.org/2010563004 is the CL that added this).
> erikchen@: can you please confirm? In which case, we wouldn't need the
> |out_of_memory| param. A null return value would imply OOM.

right. no IPC means this is no longer necessary.

[sadrul, 2016-12-08 04:29:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 04:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 04:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:32:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sadrul, 2016-12-08 04:53:11]

Patchset #3 (id:40001) has been deleted

[sadrul, 2016-12-08 04:53:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 04:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-08 04:54:14]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-12-08 04:56:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[commit-bot: I haz the power, 2016-12-08 04:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:58:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sadrul, 2016-12-08 05:02:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-08 05:06:25]

Description was changed from

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore.

BUG=612500
==========

to

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500
==========

[sadrul, 2016-12-08 06:08:07]

On 2016/12/08 03:36:02, erikchen wrote:
>
https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
> File content/child/child_thread_impl.cc (right):
> 
>
https://codereview.chromium.org/2544953002/diff/1/content/child/child_thread_...
> content/child/child_thread_impl.cc:733: *out_of_memory = true;
> On 2016/12/08 03:27:52, sadrul wrote:
> > On 2016/12/02 19:58:08, nasko (very slow til Dec 13th) wrote:
> > > Do we care to disambiguate an out of memory condition (this branch) vs the
> > > failure to unwrap (the next if condition)? Seems like only consumer is
> > > child_shared_bitmap_manager.cc.
> > 
> > Looks like the original failure mode during teardown no longer applies
> > (https://codereview.chromium.org/2010563004 is the CL that added this).
> > erikchen@: can you please confirm? In which case, we wouldn't need the
> > |out_of_memory| param. A null return value would imply OOM.
> 
> right. no IPC means this is no longer necessary.

Awesome, thanks! I have gone ahead and made this change. Mind taking another
look?

[commit-bot: I haz the power, 2016-12-08 06:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 06:14:06]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-12-08 17:47:53]

lgtm

[nasko, 2016-12-08 18:40:10]

https://codereview.chromium.org/2544953002/diff/80001/content/child/child_thr...
File content/child/child_thread_impl.h (right):

https://codereview.chromium.org/2544953002/diff/80001/content/child/child_thr...
content/child/child_thread_impl.h:112: // A static variant that can be called on
background threads.
A static variant of what? The non-static method is now gone, so the comment
should be updated.

[sadrul, 2016-12-08 19:49:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-12-08 19:50:23]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-08 19:50:38]

Patchset #4 (id:100001) has been deleted

[sadrul, 2016-12-08 19:51:00]

https://codereview.chromium.org/2544953002/diff/80001/content/child/child_thr...
File content/child/child_thread_impl.h (right):

https://codereview.chromium.org/2544953002/diff/80001/content/child/child_thr...
content/child/child_thread_impl.h:112: // A static variant that can be called on
background threads.
On 2016/12/08 18:40:10, nasko (very slow til Dec 13th) wrote:
> A static variant of what? The non-static method is now gone, so the comment
> should be updated.

Done.

[commit-bot: I haz the power, 2016-12-08 19:54:42]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2016-12-08 21:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:06:38]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-09 04:17:24]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-12-09 04:17:24]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2544953002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-12-09 04:17:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 04:22:05]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481257044437710,
"parent_rev": "a309cba76aebd453dc153c04b2deed67dfba5f74", "commit_rev":
"dc6e945aef04d2dd480e62cd0ff7dcc2698266e6"}

[commit-bot: I haz the power, 2016-12-09 04:22:30]

Description was changed from

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500
==========

to

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500
==========

[commit-bot: I haz the power, 2016-12-09 04:22:31]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-12-09 04:26:03]

Description was changed from

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500
==========

to

==========
content: Some code cleanup related to shared memory allocation.

After https://crrev.com/432737, memory allocation does not do IPC
anymore. So it does not need the IPC::Sender anymore. Also, it is no
longer necessary to have special code to decide when the allocation
request failed due to out-of-memory. So remove that code too.

BUG=612500

Committed: https://crrev.com/ee3ff1ffb2acc57ffe1668c603d79debcc463b8c
Cr-Commit-Position: refs/heads/master@{#437463}
==========

[commit-bot: I haz the power, 2016-12-09 04:26:04]

Patchset 4 (id:??) landed as
https://crrev.com/ee3ff1ffb2acc57ffe1668c603d79debcc463b8c
Cr-Commit-Position: refs/heads/master@{#437463}