Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010563004: content: Not all memory creation failures are out of memory errors. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Not all memory creation failures are out of memory errors. It is possible that the child process is shutting down, and the failure is expected. BUG=585013 Committed: https://crrev.com/4e01cbe3db01f86ee5ef3c5acdd84d261501faef Cr-Commit-Position: refs/heads/master@{#395996}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M content/child/blob_storage/webblobregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 1 chunk +14 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010563004/1
4 years, 7 months ago (2016-05-25 18:01:32 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/71831) cast_shell_android on ...
4 years, 7 months ago (2016-05-25 18:11:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010563004/20001
4 years, 7 months ago (2016-05-25 18:15:08 UTC) #6
erikchen
avi: Please review.
4 years, 7 months ago (2016-05-25 19:31:01 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 20:25:56 UTC) #10
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 20:26:10 UTC) #11
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-25 21:40:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010563004/20001
4 years, 7 months ago (2016-05-25 21:54:45 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:00:20 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:01:53 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4e01cbe3db01f86ee5ef3c5acdd84d261501faef
Cr-Commit-Position: refs/heads/master@{#395996}

Powered by Google App Engine
This is Rietveld 408576698