chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc - Issue 254483003: Start requiring DistillerPage for calls to DomDistillerService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc

Issue 254483003: Start requiring DistillerPage for calls to DomDistillerService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc ('k') | components/dom_distiller.gypi » ('j') | components/dom_distiller/core/dom_distiller_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc

diff --git a/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc b/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc

index 7911ff9d7ef97c73f1706ac74b502012b8ef610c..95ceb5224ef1e7cea6e4f1fb1c8d3894c917ff30 100644

--- a/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc

+++ b/chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc

@@ -18,6 +18,7 @@ using dom_distiller::test::util::CreateStoreWithFakeDB;

using dom_distiller::DomDistillerContextKeyedService;

using dom_distiller::DomDistillerService;

using dom_distiller::DistillerFactory;

+using dom_distiller::DistillerPageFactory;

using dom_distiller::DomDistillerStoreInterface;

using dom_distiller::test::MockDistillerFactory;

@@ -31,7 +32,8 @@ class ReadingListPrivateApiTest : public ExtensionApiTest {

new DomDistillerContextKeyedService(

scoped_ptr<DomDistillerStoreInterface>(

CreateStoreWithFakeDB(fake_db, FakeDB::EntryMap())),

- scoped_ptr<DistillerFactory>(factory));

+ scoped_ptr<DistillerFactory>(factory),

+ scoped_ptr<DistillerPageFactory>());

fake_db->InitCallback(true);

fake_db->LoadCallback(true);

EXPECT_CALL(*factory, CreateDistillerImpl())