chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc - Issue 254483003: Start requiring DistillerPage for calls to DomDistillerService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

Issue 254483003: Start requiring DistillerPage for calls to DomDistillerService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/dom_distiller/lazy_dom_distiller_service.cc ('k') | chrome/browser/extensions/api/reading_list_private/reading_list_private_apitest.cc » ('j') | components/dom_distiller/core/dom_distiller_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

diff --git a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

index 9f2919a3de38471570df0e01b967091e3b51d18c..3c2fc034202062fcd9464e6f5c82f94acdde75f1 100644

--- a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

+++ b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

@@ -37,7 +37,9 @@ bool ReadingListPrivateAddEntryFunction::RunImpl() {

DomDistillerService* service =

DomDistillerServiceFactory::GetForBrowserContext(GetProfile());

- const std::string& id = service->AddToList(url_to_add, base::Bind(

+ const std::string& id = service->AddToList(url_to_add,

+ service->CreateDefaultDistillerPage().Pass(),

+ base::Bind(

&ReadingListPrivateAddEntryFunction::SendResponse, this));

Entry new_entry;

new_entry.id = id;