[Chrome OS] Add a chrome os device wallpaper policy.

[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL:
https://codereview.chromium.org/2572793003/.

BUG=475998
Committed: https://crrev.com/0823eab840a0a2c22692be4c21870a0c51e07e0e
Cr-Commit-Position: refs/heads/master@{#438592}

[xdai1, 2016-12-01 00:23:51]

Patchset #1 (id:1) has been deleted

[xdai1, 2016-12-01 18:05:15]

Description was changed from

==========
[Wallpaper] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

BUG=475998
==========

to

==========
[Wallpaper] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy will be addressed in another CL.

BUG=475998
==========

[xdai1, 2016-12-01 18:50:33]

Patchset #1 (id:20001) has been deleted

[xdai1, 2016-12-01 18:51:21]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:51:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xdai1, 2016-12-01 19:11:49]

xdai@chromium.org changed reviewers:
+ achuith@chromium.org, asvitkine@chromium.org, bartfab@chromium.org

[xdai1, 2016-12-01 19:11:49]

Hi bartfab@, achuith@, asvitkine@, could you help review this CL please? Thanks!

bartfab@: all
achuith@: files in chromeos/settings
asvitkine@: histograms.xml

[commit-bot: I haz the power, 2016-12-01 19:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:33:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[achuithb, 2016-12-01 20:32:59]

On 2016/12/01 19:11:49, xdai1 wrote:
> Hi bartfab@, achuith@, asvitkine@, could you help review this CL please?
Thanks!
> 
> bartfab@: all
> achuith@: files in chromeos/settings

lgtm for cros/settings

> asvitkine@: histograms.xml

[Alexei Svitkine (slow), 2016-12-02 17:15:58]

lgtm

[xdai1, 2016-12-06 01:44:09]

Patchset #3 (id:80001) has been deleted

[xdai1, 2016-12-07 23:12:37]

Patchset #3 (id:100001) has been deleted

[xdai1, 2016-12-13 22:39:49]

Patchset #3 (id:120001) has been deleted

[xdai1, 2016-12-13 22:45:06]

xdai@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[xdai1, 2016-12-13 22:45:06]

pastarmovj@, could you help review this CL please? Seems bartfab@ will be OOO
until Jan. Thanks!

[xdai1, 2016-12-13 22:45:22]

Description was changed from

==========
[Wallpaper] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy will be addressed in another CL.

BUG=475998
==========

to

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy will be addressed in another CL.

BUG=475998
==========

[xdai1, 2016-12-13 23:05:50]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:06:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 00:09:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 00:09:41]

Dry run: This issue passed the CQ dry run.

[pastarmovj, 2016-12-14 10:55:02]

policy lgtm with two nits.

https://codereview.chromium.org/2544693002/diff/140001/chrome/test/data/polic...
File chrome/test/data/policy/policy_test_cases.json (right):

https://codereview.chromium.org/2544693002/diff/140001/chrome/test/data/polic...
chrome/test/data/policy/policy_test_cases.json:3031: "hash":
"examplewallpaperexamplewallpaperexamplewallpaperexamplewallpaper"
nit: does this have to be so long to be accepted by the code or cane we go with
a single examplewallpaper isntead? :)

https://codereview.chromium.org/2544693002/diff/140001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2544693002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:9352: 'supported_on':
['chrome_os:57-'],
Please add 'future': True and only remove it when the whole policy is ready.
Unless everything else has landed in which case you can remove the last
paragraph of the CL description or change it to reference the implementation
instead.

[xdai1, 2016-12-14 18:21:52]

Description was changed from

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy will be addressed in another CL.

BUG=475998
==========

to

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL: 
https://codereview.chromium.org/2572793003/.

BUG=475998
==========

[xdai1, 2016-12-14 18:22:25]

pastarmovj@, I've addressed your comments. Thanks for your review!

https://codereview.chromium.org/2544693002/diff/140001/chrome/test/data/polic...
File chrome/test/data/policy/policy_test_cases.json (right):

https://codereview.chromium.org/2544693002/diff/140001/chrome/test/data/polic...
chrome/test/data/policy/policy_test_cases.json:3031: "hash":
"examplewallpaperexamplewallpaperexamplewallpaperexamplewallpaper"
On 2016/12/14 10:55:02, pastarmovj wrote:
> nit: does this have to be so long to be accepted by the code or cane we go
with
> a single examplewallpaper isntead? :)

It doesn't have to be so long to pass the test, so I reduced it to
"examplewallpaerhash" as you suggested.

https://codereview.chromium.org/2544693002/diff/140001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2544693002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:9352: 'supported_on':
['chrome_os:57-'],
On 2016/12/14 10:55:02, pastarmovj wrote:
> Please add 'future': True and only remove it when the whole policy is ready.
> Unless everything else has landed in which case you can remove the last
> paragraph of the CL description or change it to reference the implementation
> instead.

The CL to implement the policy is ready to land
https://codereview.chromium.org/2572793003/. I'll land this policy CL first
following by the implementation CL. I updated the CL description as you
suggestd.

[xdai1, 2016-12-14 18:23:45]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2016-12-14 18:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
achuith@chromium.org, asvitkine@chromium.org, pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2544693002/#ps160001
(title: "Address pastarmovj@'s comments.")

[commit-bot: I haz the power, 2016-12-14 18:24:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:34:23]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1481739825645690,
"parent_rev": "d3506ca26e72123529ba76b96b2a7b7d9866b305", "commit_rev":
"576cc9ba4e28f566849070bc9a174e603c2fb498"}

[commit-bot: I haz the power, 2016-12-14 19:34:59]

Description was changed from

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL: 
https://codereview.chromium.org/2572793003/.

BUG=475998
==========

to

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL: 
https://codereview.chromium.org/2572793003/.

BUG=475998

Review-Url: https://codereview.chromium.org/2544693002
==========

[commit-bot: I haz the power, 2016-12-14 19:35:00]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2016-12-14 19:36:38]

Description was changed from

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL: 
https://codereview.chromium.org/2572793003/.

BUG=475998

Review-Url: https://codereview.chromium.org/2544693002
==========

to

==========
[Chrome OS] Add a chrome os device wallpaper policy.

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL:
https://codereview.chromium.org/2572793003/.

BUG=475998

Committed: https://crrev.com/0823eab840a0a2c22692be4c21870a0c51e07e0e
Cr-Commit-Position: refs/heads/master@{#438592}
==========

[commit-bot: I haz the power, 2016-12-14 19:36:40]

Patchset 4 (id:??) landed as
https://crrev.com/0823eab840a0a2c22692be4c21870a0c51e07e0e
Cr-Commit-Position: refs/heads/master@{#438592}