Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2544613004: Reland: Notifications: Split up image loading histograms by image type (Closed)

Created:
4 years ago by johnme
Modified:
4 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, haraken, Peter Beverloo, awdf+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Notifications: Split up image loading histograms by image type Reland of https://codereview.chromium.org/2540763002 which was reverted in https://codereview.chromium.org/2540423003. Test has been fixed. It'll be useful to compare timings and byte sizes for the different image types (content image, icon, badge, action icon). BUG=669621, 614456 TBR=isherman@chromium.org (histograms unchanged from reverted patch) Committed: https://crrev.com/548de683cebfaf09526f22bfa922512a114c251a Cr-Commit-Position: refs/heads/master@{#435705}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
johnme
This is the same as https://codereview.chromium.org/2540763002 except NotificationImageLoaderTest.cpp no longer tests expectTotalCount("Notifications.LoadFailTime.Icon", 0) since it's ...
4 years ago (2016-12-01 16:55:05 UTC) #4
Peter Beverloo
lgtm
4 years ago (2016-12-01 16:56:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544613004/1
4 years ago (2016-12-01 16:57:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:53:17 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 20:56:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/548de683cebfaf09526f22bfa922512a114c251a
Cr-Commit-Position: refs/heads/master@{#435705}

Powered by Google App Engine
This is Rietveld 408576698