Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2540423003: Revert "Notifications: Split up image loading histograms by image type" (Closed)

Created:
4 years ago by jbroman
Modified:
4 years ago
Reviewers:
johnme
CC:
chromium-reviews, blink-reviews, haraken, Peter Beverloo, awdf+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Notifications: Split up image loading histograms by image type" This reverts commit 468ed78ec76f5db7d89a0829b33c0f6427553411. https://codereview.chromium.org/2540763002/ Failing on bots. NotificationImageLoaderTest.SuccessTest (run #1): [ RUN ] NotificationImageLoaderTest.SuccessTest ../../base/test/histogram_tester.cc:158: Failure Value of: actual_count Actual: 1 Expected: expected_count Which is: 0 Histogram "Notifications.LoadFinishTime.Icon" does not have the right number of samples (0) in the expected bucket (0). It has (1). [ FAILED ] NotificationImageLoaderTest.SuccessTest (5 ms) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20543 BUG=669621, 614456 TBR=johnme@chromium.org NOTRY=true Committed: https://crrev.com/df48f17f5512fa5a727e63290aded588bc776751 Cr-Commit-Position: refs/heads/master@{#435622}

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540423003/1
4 years ago (2016-12-01 16:21:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 16:25:43 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-01 16:28:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df48f17f5512fa5a727e63290aded588bc776751
Cr-Commit-Position: refs/heads/master@{#435622}

Powered by Google App Engine
This is Rietveld 408576698