Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 25446005: Trigger full html.css styles for some printing tests. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Trigger full html.css styles for some printing tests. In Blink, @page UA styles is missing from the simple html stylesheet which is used instead of html.css for documents which contains a certain subset of html element types. Adding that @page rule to that simplified stylesheet will change the actual results for these tests which have expectations relying on that bug[1]: PrintWebViewHelperPreviewTest.PrintPreviewShrinkToFitPage PrintWebViewHelperPreviewTest.PrintPreviewCenterToFitPage This CL changes the expected results and adds a <p> element to those tests in order to trigger the correct @page rule from html.css without the fix in Blink. Then the Blink fix[2] can land and be rolled into chromium without affecting the results of the mentioned tests. After the Blink fix is rolled into chromium, the <p> elements can be safely removed again. [1] https://code.google.com/p/chromium/issues/detail?id=304021 [2] https://codereview.chromium.org/25856002/ R=vitalybuka@chromium.org BUG=304021 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rune
7 years, 2 months ago (2013-10-04 09:36:08 UTC) #1
ojan
lgtm. I don't have owners permission for this directory though.
7 years, 2 months ago (2013-10-04 16:50:44 UTC) #2
ojan
7 years, 2 months ago (2013-10-04 16:51:02 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 2 months ago (2013-10-04 17:31:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25446005/1
7 years, 2 months ago (2013-10-04 17:31:42 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 20:33:30 UTC) #6
Message was sent while issue was closed.
Change committed as 227076

Powered by Google App Engine
This is Rietveld 408576698