chrome/renderer/printing/print_web_view_helper_browsertest.cc - Issue 25446005: Trigger full html.css styles for some printing tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_browsertest.cc

Issue 25446005: Trigger full html.css styles for some printing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/printing/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_browsertest.cc b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

index 93fc332dc174f9c343763c81aa3b9b050ab4282c..e7325cb979f519cce1cd3322ad5ef3cf3e4a48f5 100644

--- a/chrome/renderer/printing/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

@@ -51,7 +51,7 @@ const char kHTMLWithPageSizeCss[] =

" }"

"}"

"</style></head>"

- "<body>Lorem Ipsum:"

+ "<body>Lorem Ipsum:<p>"

"</body></html>";

// A simple web page with print page layout css.

@@ -669,7 +669,7 @@ TEST_F(PrintWebViewHelperPreviewTest, PrintPreviewCenterToFitPage) {

OnPrintPreview(dict);

EXPECT_EQ(0, chrome_render_thread_->print_preview_pages_remaining());

- VerifyDefaultPageLayout(288, 288, 252, 252, 162, 162, true);

+ VerifyDefaultPageLayout(216, 216, 288, 288, 198, 198, true);

VerifyPrintPreviewCancelled(false);

VerifyPrintPreviewFailed(false);

VerifyPrintPreviewGenerated(true);

@@ -687,7 +687,7 @@ TEST_F(PrintWebViewHelperPreviewTest, PrintPreviewShrinkToFitPage) {

" }"

"}"

"</style></head>"

- "<body>Lorem Ipsum:"

+ "<body>Lorem Ipsum:<p>"

"</body></html>";

LoadHTML(kHTMLWithPageCss);

@@ -699,7 +699,7 @@ TEST_F(PrintWebViewHelperPreviewTest, PrintPreviewShrinkToFitPage) {

OnPrintPreview(dict);

EXPECT_EQ(0, chrome_render_thread_->print_preview_pages_remaining());

- VerifyDefaultPageLayout(612, 693, 49, 50, 0, 0, true);

+ VerifyDefaultPageLayout(571, 652, 69, 71, 20, 21, true);

VerifyPrintPreviewCancelled(false);

VerifyPrintPreviewFailed(false);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »