Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 254453002: Fix WebGL context restoration logic. The retry mechanism was broken when the ownership of the WebGr… (Closed)

Created:
6 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
blink-reviews, jamesr, krit, dsinclair, rwlbuis, jbroman, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, pdr., ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix WebGL context restoration logic. The retry mechanism was broken when the ownership of the WebGraphicsContext3D was transferred to the DrawingBuffer. The Telemetry based context loss test is being made more of a stress test to verify this fix. Will also attempt to make the WebGL conformance tests more stressful to catch the underlying race condition more reliably. BUG=365904 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172465

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added more safety checks upon context restoration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -23 lines) Patch
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 3 chunks +7 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 4 chunks +26 lines, -10 lines 0 comments Download
M Source/platform/graphics/gpu/Extensions3DUtil.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 1 chunk +21 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 8 months ago (2014-04-23 22:52:14 UTC) #1
bajones
https://codereview.chromium.org/254453002/diff/1/Source/platform/graphics/gpu/DrawingBuffer.cpp File Source/platform/graphics/gpu/DrawingBuffer.cpp (right): https://codereview.chromium.org/254453002/diff/1/Source/platform/graphics/gpu/DrawingBuffer.cpp#newcode84 Source/platform/graphics/gpu/DrawingBuffer.cpp:84: OwnPtr<Extensions3DUtil> extensionsUtil = Extensions3DUtil::create(context.get()); I wonder if the patch ...
6 years, 8 months ago (2014-04-23 23:52:51 UTC) #2
Zhenyao Mo
I think the Extensions3DUtil should be owned by WebGraphicsContext3D, right now it's messy. But to ...
6 years, 8 months ago (2014-04-23 23:57:40 UTC) #3
Ken Russell (switch to Gerrit)
On 2014/04/23 23:52:51, bajones wrote: > https://codereview.chromium.org/254453002/diff/1/Source/platform/graphics/gpu/DrawingBuffer.cpp > File Source/platform/graphics/gpu/DrawingBuffer.cpp (right): > > https://codereview.chromium.org/254453002/diff/1/Source/platform/graphics/gpu/DrawingBuffer.cpp#newcode84 > ...
6 years, 8 months ago (2014-04-23 23:59:19 UTC) #4
Ken Russell (switch to Gerrit)
I added a couple more safety checks to DrawingBuffer::initialize() and Extensions3DUtil::initializeExtensions to try to catch ...
6 years, 8 months ago (2014-04-24 00:42:24 UTC) #5
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-24 00:42:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/254453002/20001
6 years, 8 months ago (2014-04-24 00:42:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 01:19:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-24 01:20:00 UTC) #9
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-24 01:26:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/254453002/20001
6 years, 8 months ago (2014-04-24 01:27:03 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 01:54:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-24 01:54:22 UTC) #13
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-24 02:05:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/254453002/20001
6 years, 8 months ago (2014-04-24 02:06:15 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 03:20:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-24 03:20:28 UTC) #17
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-24 06:50:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/254453002/20001
6 years, 8 months ago (2014-04-24 06:51:06 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 07:57:55 UTC) #20
Message was sent while issue was closed.
Change committed as 172465

Powered by Google App Engine
This is Rietveld 408576698