Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: Source/platform/graphics/gpu/Extensions3DUtil.h

Issue 254453002: Fix WebGL context restoration logic. The retry mechanism was broken when the ownership of the WebGr… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added more safety checks upon context restoration. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/gpu/DrawingBuffer.cpp ('k') | Source/platform/graphics/gpu/Extensions3DUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/gpu/Extensions3DUtil.h
diff --git a/Source/platform/graphics/gpu/Extensions3DUtil.h b/Source/platform/graphics/gpu/Extensions3DUtil.h
index 88adc322f0ed786b59d49bc101cc089abe01bbf1..3251192950ef5425fb819327fcfc5d17dd2a7be3 100644
--- a/Source/platform/graphics/gpu/Extensions3DUtil.h
+++ b/Source/platform/graphics/gpu/Extensions3DUtil.h
@@ -20,7 +20,8 @@ namespace WebCore {
class PLATFORM_EXPORT Extensions3DUtil {
public:
- Extensions3DUtil(blink::WebGraphicsContext3D*);
+ // Creates a new Extensions3DUtil. If the passed WebGraphicsContext3D has been spontaneously lost, returns null.
+ static PassOwnPtr<Extensions3DUtil> create(blink::WebGraphicsContext3D*);
~Extensions3DUtil();
bool supportsExtension(const String& name);
@@ -30,7 +31,8 @@ public:
static bool canUseCopyTextureCHROMIUM(GLenum destFormat, GLenum destType, GLint level);
private:
- void initializeExtensions();
+ Extensions3DUtil(blink::WebGraphicsContext3D*);
+ bool initializeExtensions();
blink::WebGraphicsContext3D* m_context;
HashSet<String> m_enabledExtensions;
« no previous file with comments | « Source/platform/graphics/gpu/DrawingBuffer.cpp ('k') | Source/platform/graphics/gpu/Extensions3DUtil.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698