Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: media/mojo/interfaces/media_service.mojom

Issue 2544523002: Pass Connector* into MojoMediaClient::Initialize(). (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/interfaces/media_service.mojom
diff --git a/media/mojo/interfaces/media_service.mojom b/media/mojo/interfaces/media_service.mojom
index 3acfa3aef67c7dc1e375e76c3079a7250e642fec..952a957be98849c06bb9e0e4ca77165d09605a17 100644
--- a/media/mojo/interfaces/media_service.mojom
+++ b/media/mojo/interfaces/media_service.mojom
@@ -8,6 +8,10 @@ import "media/mojo/interfaces/interface_factory.mojom";
import "services/service_manager/public/interfaces/interface_provider.mojom";
interface MediaService {
- CreateInterfaceFactory(InterfaceFactory& factory,
- service_manager.mojom.InterfaceProvider frame_interfaces);
+ // Request an InterfaceFactory. |frame_interfaces| can optionally be used to
xhwang 2016/11/30 18:49:31 nit: Request_s_
slan 2016/12/01 00:47:22 Done.
+ // provide interfaces hosted by the caller to the remote InterfaceFactory
+ // implementation.
+ CreateInterfaceFactory(
+ InterfaceFactory& factory,
+ service_manager.mojom.InterfaceProvider? frame_interfaces);
alokp 2016/11/30 17:36:20 nit: I do not quite like the name frame_interfaces
slan 2016/11/30 17:40:39 client_interfaces? (As Xiaohan mentioned somewhere
xhwang 2016/11/30 18:49:31 Naming is hard :) The context is here: https://bu
slan 2016/12/01 00:47:22 I like host_interfaces. Done.
};

Powered by Google App Engine
This is Rietveld 408576698