media/mojo/interfaces/media_service.mojom - Issue 2544523002: Pass Connector* into MojoMediaClient::Initialize().

Side by Side Diff: media/mojo/interfaces/media_service.mojom

Issue 2544523002: Pass Connector* into MojoMediaClient::Initialize(). (Closed)

Patch Set: Rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chromecast/media/service/cast_mojo_media_client.cc ('k') | media/mojo/services/android_mojo_media_client.cc » ('j') | media/mojo/services/android_mojo_media_client.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module media.mojom;	5 module media.mojom;

6	6

7 import "media/mojo/interfaces/interface_factory.mojom";	7 import "media/mojo/interfaces/interface_factory.mojom";

8 import "services/service_manager/public/interfaces/interface_provider.mojom";	8 import "services/service_manager/public/interfaces/interface_provider.mojom";

9	9

10 interface MediaService {	10 interface MediaService {

11 CreateInterfaceFactory(InterfaceFactory& factory,	11 // Request an InterfaceFactory. \|frame_interfaces\| can optionally be used to
	xhwang 2016/11/30 18:49:31 nit: Request_s_ nit: Request_s_ slan 2016/12/01 00:47:22 Done. Show quoted text On 2016/11/30 18:49:31, xhwang wrote: > nit: Request_s_ Done.
12 service_manager.mojom.InterfaceProvider frame_interfaces) ;	12 // provide interfaces hosted by the caller to the remote InterfaceFactory

	13 // implementation.

	14 CreateInterfaceFactory(

	15 InterfaceFactory& factory,

	16 service_manager.mojom.InterfaceProvider? frame_interfaces);
	alokp 2016/11/30 17:36:20 nit: I do not quite like the name frame_interfaces nit: I do not quite like the name frame_interfaces, which kind of suggests that this interface is somehow tied to render frames. We should make it more generic, something like, remote_interfaces, maybe? slan 2016/11/30 17:40:39 client_interfaces? (As Xiaohan mentioned somewhere Show quoted text On 2016/11/30 17:36:20, alokp wrote: > nit: I do not quite like the name frame_interfaces, which kind of suggests that > this interface is somehow tied to render frames. We should make it more generic, > something like, remote_interfaces, maybe? client_interfaces? (As Xiaohan mentioned somewhere else, this should be deprecated in favor of a delegate interface) xhwang 2016/11/30 18:49:31 Naming is hard :) The context is here: https://bu Show quoted text On 2016/11/30 17:40:39, slan wrote: > On 2016/11/30 17:36:20, alokp wrote: > > nit: I do not quite like the name frame_interfaces, which kind of suggests > that > > this interface is somehow tied to render frames. We should make it more > generic, > > something like, remote_interfaces, maybe? > > client_interfaces? (As Xiaohan mentioned somewhere else, this should be > deprecated in favor of a delegate interface) Naming is hard :) The context is here: https://bugs.chromium.org/p/chromium/issues/detail?id=660573 This interface is provided by whoever calling CreateInterfaceFactory, which may or may not be the final client of the InterfaceFactory. So client_interfaces is a bit ambiguous. I think "remote_interfaces" would be better. Today the only place providing this is in a "frame", hence the current name. Maybe we should just introduce a new term, e.g. "host", which is the caller of CreateInterfaceFactory(), then this would be "host_interfaces". But given the fact that we want to replace this altogether, it's totally up to you whether you want to do the rename or not in this CL. slan 2016/12/01 00:47:22 I like host_interfaces. Done. Show quoted text On 2016/11/30 18:49:31, xhwang wrote: > On 2016/11/30 17:40:39, slan wrote: > > On 2016/11/30 17:36:20, alokp wrote: > > > nit: I do not quite like the name frame_interfaces, which kind of suggests > > that > > > this interface is somehow tied to render frames. We should make it more > > generic, > > > something like, remote_interfaces, maybe? > > > > client_interfaces? (As Xiaohan mentioned somewhere else, this should be > > deprecated in favor of a delegate interface) > > Naming is hard :) > > The context is here: > https://bugs.chromium.org/p/chromium/issues/detail?id=660573 > > This interface is provided by whoever calling CreateInterfaceFactory, which may > or may not be the final client of the InterfaceFactory. So client_interfaces is > a bit ambiguous. I think "remote_interfaces" would be better. Today the only > place providing this is in a "frame", hence the current name. > > Maybe we should just introduce a new term, e.g. "host", which is the caller of > CreateInterfaceFactory(), then this would be "host_interfaces". > > But given the fact that we want to replace this altogether, it's totally up to > you whether you want to do the rename or not in this CL. I like host_interfaces. Done.
13 };	17 };

OLD	NEW