MD Settings: simplify spelling service toggle and make it respect policy

MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/119a280cbd120b06bd7ce82f890624de5ca57e13
Cr-Commit-Position: refs/heads/master@{#436106}

[Dan Beam, 2016-12-01 04:53:47]

Description was changed from

==========
MD Settings: simplify spelling service checkbox and make it respect policy

R=dschuyler@chromium.org
BUG=614265
==========

to

==========
MD Settings: simplify spelling service checkbox and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-01 04:54:02]

Description was changed from

==========
MD Settings: simplify spelling service checkbox and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-01 04:55:45]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-12-01 04:56:05]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 04:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 05:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 05:57:52]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-12-02 02:38:53]

https://codereview.chromium.org/2544453003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2544453003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:155:
</settings-toggle-button>
Is there a way to preserve the on-tap for the entire settings box?

I know that not all of the rows are entirely clickable, but that is the goal. So
I'm hesitant to lose one that is on the whole row now?

Or am I misunderstanding, does this get the whole row?

[Dan Beam, 2016-12-02 04:07:35]

https://codereview.chromium.org/2544453003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2544453003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:155:
</settings-toggle-button>
On 2016/12/02 02:38:53, dschuyler wrote:
> Is there a way to preserve the on-tap for the entire settings box?
> 
> I know that not all of the rows are entirely clickable, but that is the goal.
So
> I'm hesitant to lose one that is on the whole row now?
> 
> Or am I misunderstanding, does this get the whole row?

yeah, do this:
https://codereview.chromium.org/2538373002/diff/40001/chrome/browser/resource...

[dschuyler, 2016-12-02 21:43:18]

lgtm

[Dan Beam, 2016-12-02 23:09:33]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-12-02 23:10:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:46:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480720173689630,
"parent_rev": "96c2d43e7437fef2d5d9588d5d174e2e893014a7", "commit_rev":
"538a404a3a26e53e67e1c04957fedd834ba07cab"}

[commit-bot: I haz the power, 2016-12-03 00:46:32]

Description was changed from

==========
MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-03 00:46:33]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-03 00:48:53]

Description was changed from

==========
MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/119a280cbd120b06bd7ce82f890624de5ca57e13
Cr-Commit-Position: refs/heads/master@{#436106}
==========

[commit-bot: I haz the power, 2016-12-03 00:48:55]

Patchset 1 (id:??) landed as
https://crrev.com/119a280cbd120b06bd7ce82f890624de5ca57e13
Cr-Commit-Position: refs/heads/master@{#436106}