Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Side by Side Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2544453003: MD Settings: simplify spelling service toggle and make it respect policy (Closed)
Patch Set: stray </div> Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_cs s.html"> 1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_cs s.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
8 <link rel="import" href="/clear_browsing_data_dialog/clear_browsing_data_dialog. html"> 8 <link rel="import" href="/clear_browsing_data_dialog/clear_browsing_data_dialog. html">
9 <link rel="import" href="/controls/settings_checkbox.html"> 9 <link rel="import" href="/controls/settings_checkbox.html">
10 <link rel="import" href="/controls/settings_toggle_button.html"> 10 <link rel="import" href="/controls/settings_toggle_button.html">
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 pref="{{prefs.cros.device.attestation_for_content_protection_enabl ed}}" 140 pref="{{prefs.cros.device.attestation_for_content_protection_enabl ed}}"
141 label="$i18n{enableContentProtectionAttestation}"> 141 label="$i18n{enableContentProtectionAttestation}">
142 </settings-checkbox> 142 </settings-checkbox>
143 <settings-checkbox 143 <settings-checkbox
144 pref="{{prefs.settings.internet.wake_on_wifi_darkconnect}}" 144 pref="{{prefs.settings.internet.wake_on_wifi_darkconnect}}"
145 label="$i18n{wakeOnWifi}"> 145 label="$i18n{wakeOnWifi}">
146 </settings-checkbox> 146 </settings-checkbox>
147 </if> 147 </if>
148 </div> 148 </div>
149 <if expr="_google_chrome"> 149 <if expr="_google_chrome">
150 <div class="settings-box two-line" actionable 150 <div class="settings-box two-line">
151 on-tap="onUseSpellingServiceTap_"> 151 <settings-toggle-button class="start"
152 <div class="start"> 152 pref="{{prefs.spellcheck.use_spelling_service}}"
153 $i18n{spellingPref} 153 label="$i18n{spellingPref}"
154 <div class="secondary">$i18n{spellingDescription}</div> 154 sub-label="$i18n{spellingDescription}">
155 </div> 155 </settings-toggle-button>
dschuyler 2016/12/02 02:38:53 Is there a way to preserve the on-tap for the enti
Dan Beam 2016/12/02 04:07:35 yeah, do this: https://codereview.chromium.org/253
156 <paper-toggle-button id="spellingServiceToggleButton">
157 </paper-toggle-button>
158 </div> 156 </div>
159 </if> 157 </if>
160 <if expr="use_nss_certs or is_win or is_macosx"> 158 <if expr="use_nss_certs or is_win or is_macosx">
161 <div id="manageCertificates" class="settings-box two-line" 159 <div id="manageCertificates" class="settings-box two-line"
162 actionable on-tap="onManageCertificatesTap_"> 160 actionable on-tap="onManageCertificatesTap_">
163 <div class="start"> 161 <div class="start">
164 <div>$i18n{manageCertificates}</div> 162 <div>$i18n{manageCertificates}</div>
165 <div class="secondary">$i18n{manageCertificatesDescription}</div> 163 <div class="secondary">$i18n{manageCertificatesDescription}</div>
166 </div> 164 </div>
167 <button class="subpage-arrow" is="paper-icon-button-light"></button> 165 <button class="subpage-arrow" is="paper-icon-button-light"></button>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 $i18n{siteSettingsCookieRemoveAll} 382 $i18n{siteSettingsCookieRemoveAll}
385 </paper-button> 383 </paper-button>
386 <site-data-details-subpage page-title="{{pageTitle}}"> 384 <site-data-details-subpage page-title="{{pageTitle}}">
387 </site-data-details-subpage> 385 </site-data-details-subpage>
388 </settings-subpage> 386 </settings-subpage>
389 </template> 387 </template>
390 </settings-animated-pages> 388 </settings-animated-pages>
391 </template> 389 </template>
392 <script src="privacy_page.js"></script> 390 <script src="privacy_page.js"></script>
393 </dom-module> 391 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698