Issue 25443008: Fix an uninitialized field in the fileSystem.retainEntry implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25443008: Fix an uninitialized field in the fileSystem.retainEntry implementation. (Closed)

Created:
7 years, 2 months ago by Sam McNally

Modified:
7 years, 2 months ago

Reviewers:
benwells

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix an uninitialized field in the fileSystem.retainEntry implementation. This caused files to be sometimes retained as directories, making it impossible to restore access to them. BUG=301692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226453

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/extensions/api/file_system/file_system_api.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	chrome/browser/extensions/api/file_system/file_system_apitest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/25443008/1

7 years, 2 months ago (2013-10-02 10:01:32 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-02 11:35:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/25443008/1

7 years, 2 months ago (2013-10-02 11:52:21 UTC) #5

Message was sent while issue was closed.

Change committed as 226453

Expand Messages | Collapse Messages