chrome/browser/extensions/api/file_system/file_system_api.cc - Issue 25443008: Fix an uninitialized field in the fileSystem.retainEntry implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 25443008: Fix an uninitialized field in the fileSystem.retainEntry implementation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/file_system/file_system_api.cc

diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc

index d66afb63ad996ca4e9d62ca713a9f5302cddddb3..ea2a23f57f749f6ce9863be06a2ad832d6e92574 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api.cc

+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc

@@ -974,9 +974,7 @@ void FileSystemRetainEntryFunction::RetainFileEntry(

}

void FileSystemRetainEntryFunction::SetIsDirectoryOnFileThread() {

- if (base::DirectoryExists(path_)) {

- is_directory_ = true;

- }

+ is_directory_ = base::DirectoryExists(path_);

}

bool FileSystemIsRestorableFunction::RunImpl() {

« no previous file with comments | « no previous file | chrome/browser/extensions/api/file_system/file_system_apitest.cc » ('j') | no next file with comments »